When to abort the Code Review process
Let’s not list the many reasons to abort a Pull Request Code Review. Ask yourself this fundamental question instead: How feasible is it for the contributor to modify their code based on the feedback?
When the feedback concerns convoluted solutions, hard-to-justify abstractions or overlooked architectural trade-offs, the answer might be: not easy at all, especially when the contributor would benefit from additional experience in these areas.
In that case, stop commenting.
It's less frustrating and more effective to discuss the Pull Request on a call. Face-to-face conversations facilitate asking questions, discussing trade-offs and discovering alternative approaches. Use a high-bandwidth medium like Zoom. It will be a time-saver.
Member discussion